Support Arrays in browserify conf #280
Conversation
| @@ -39,7 +39,11 @@ function configure(bundler, cfg) { | |||
| if (type === 'transform' && typeof o[type] === 'object') { | |||
| bundler[type](o[type].name, _.omit(o[type], 'name')); | |||
| } else { | |||
| bundler[type](o[type], _.omit(o, type)); | |||
| var values = o[type]; | |||
| if (!Array.isArray(values)) values = [values]; | |||
There was a problem hiding this comment.
missing { } for if statement body
`exclude` and `ignore` would not accept an Array of paths before, since `Browserify.prototype.exclude/ignore` was expecting a single file as argument.
dasilvacontin
force-pushed
the
support-browserify-array-opts
branch
from
cfc092e
to
a3f94e0
Compare
|
Please double check if the change does not break some other option that only accepts an array, since I didn't check it myself. |
|
@dasilvacontin please check that or better yet write a test for this. |
(gotta go, will investigate the others later) |
Before,
excludeandignorewould not accept an Array of paths sinceBrowserify.prototype.exclude/ignorewas expecting a single file asargument.
Need to check if this change breaks behaviour for other browserify opts
that do accept or expect an Array as arg.